Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter cleanups #13857

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dcbaker
Copy link
Member

@dcbaker dcbaker commented Nov 1, 2024

This is some of the work out of my interpreter state series, but that doesn't rely on moving to the state.

It's cleanups like removing unused members, de-duplicating data, fixing some non-optimal types, and similar

This was only used in a couple of places, and requires extra tracking to
ensure it is correct, while we already have `current_node.lineno`, which
is always accurate and up to date.

I have also fixed a potential strict-null issue by using a sentinel node
for `current_node`
Which is built, but never used
Since it's only used to check membership, a set makes more sense. Also
add some documentation to the attribute
The former performs a linear search, which is slower than the set based
search.
It's not actually useful, we can just add the root meson.build file to
the depfiles when we translate the meson.build into ast. If there's a
provided ast then we don't go down that path anyway.
The AstInterpreter does this check as well, so don't do it twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant